Remove unnecessary ioredis types stub #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Genne23v
previously approved these changes
Feb 22, 2023
SerpentBytes
requested review from
shawnyu5 and
SerpentBytes
and removed request for
shawnyu5
SerpentBytes
previously approved these changes
Feb 22, 2023
humphd
force-pushed
the
ioredis-warning
branch
from
79d9298
to
b4b72fa
Compare
|
I don't understand why this closed. |
|
OK, fixed it. I've rebased, needs another R+ |
SerpentBytes
approved these changes
Feb 22, 2023
shawnyu5
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we don't need the ioredis stub types (they are built-in now):